Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k203] fix(indexstats): do not collect stats from "IndexStats" lookups for other query types #13000

Merged
merged 2 commits into from
May 21, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 1f5291a from #12978


What this PR does / why we need it:
indexStatsTripperware is used for resolving shards for most query types, but it also includes StatsCollectorMiddleware middleware in the chain which is not thread safe. This could result in data corruption of the collected stats since the subqueries split by time could resolve shards concurrently.

This pr makes changes to only include the stats collection middleware for actual index stats queries, other queries types will not need this.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grafanabot grafanabot requested a review from a team as a code owner May 21, 2024 07:08
@grafanabot grafanabot added backport size/S type/bug Somehing is not working as expected labels May 21, 2024
@grafanabot grafanabot requested a review from ashwanthgoli May 21, 2024 07:08
@ashwanthgoli ashwanthgoli merged commit 5b80095 into k203 May 21, 2024
58 checks passed
@ashwanthgoli ashwanthgoli deleted the backport-12978-to-k203 branch May 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants